Skip to content

Shorter code in asn1 write#715

Open
bjwtaylor wants to merge 1 commit into
Mbed-TLS:developmentfrom
bjwtaylor:shorter-code-in-asn1-write
Open

Shorter code in asn1 write#715
bjwtaylor wants to merge 1 commit into
Mbed-TLS:developmentfrom
bjwtaylor:shorter-code-in-asn1-write

Conversation

@bjwtaylor

@bjwtaylor bjwtaylor commented Mar 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Shorter code in asn1 write resolves #713

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

  • changelog not required because: No public changes
  • framework PR not required
  • mbedtls development PR not required because: No changes
  • mbedtls 3.6 PR not required because: No 3.6 backport
  • TF-PSA-Crypto 1.1 PR provided Backport 1.1: Shorter code in asn1 write #830
  • tests not required because: Existing testing suffices

@bjwtaylor bjwtaylor marked this pull request as draft March 16, 2026 15:23
Add code optimisation in asn1write
4a74be3 
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
@bjwtaylor bjwtaylor force-pushed the shorter-code-in-asn1-write branch 2 times, most recently from 2797081 to 4a74be3 Compare March 17, 2026 13:40
@bjwtaylor bjwtaylor added needs-review Every commit must be reviewed by at least two team members needs-reviewer This PR needs someone to pick it up for review priority-low Low priority - this may not receive review soon size-xs Estimated task size: extra small (a few hours at most) labels Mar 18, 2026
@bjwtaylor bjwtaylor marked this pull request as ready for review March 18, 2026 07:54
@bjwtaylor bjwtaylor requested a review from valeriosetti June 4, 2026 09:08
davidhorstmann-arm
davidhorstmann-arm approved these changes Jun 30, 2026
View reviewed changes

@davidhorstmann-arm davidhorstmann-arm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after some discussion, I'd like a backport to 1.1 (but not 3.6).

@davidhorstmann-arm davidhorstmann-arm added needs-backports Backports are missing or are pending review and approval. approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members needs-reviewer This PR needs someone to pick it up for review labels Jun 30, 2026
@bjwtaylor bjwtaylor mentioned this pull request Jul 6, 2026
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidhorstmann-arm davidhorstmann-arm davidhorstmann-arm approved these changes
@valeriosetti valeriosetti valeriosetti approved these changes

Assignees

No one assigned

Labels

approved Design and code approved - may be waiting for CI or backports needs-backports Backports are missing or are pending review and approval. priority-low Low priority - this may not receive review soon size-xs Estimated task size: extra small (a few hours at most)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Shorter code in mbedtls_asn1_write_integer?

3 participants

@bjwtaylor @davidhorstmann-arm @valeriosetti